FIX Removes warning in HGBT when fitting on dataframes #22908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
approved these changes
Mar 20, 2022
Comment on lines
+939
to
+942
| if not is_binned: | ||
| X = self._validate_data( | ||
| X, dtype=X_DTYPE, force_all_finite=False, reset=False | ||
| ) |
There was a problem hiding this comment.
I'm surprised that we have validation in this private method. Imo in the long term we should move the validation to the public methods but let's keep it that way in this PR
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #22907
What does this implement/fix? Explain your changes.
This PR removes the validation when
_in_fitis True. IfHistGradientBoosting*is infit, then the binned data was generated byHistGradientBoosting*itself in the bin mapper and does not require more validation.