[MRG] Fix tests on master, better input validation. #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -651,6 +651,9 @@ def test_classifiers_input_shapes(): | |||
| if name in ["MultinomialNB", "LabelPropagation", "LabelSpreading"]: | |||
| # TODO some complication with -1 label | |||
| continue | |||
| if name in ["DecisionTreeClassifier", "ExtraTreeClassifier"]: | |||
| # the column y interface is used by the forests | |||
There was a problem hiding this comment.
Maybe a slightly more informative comment: such as "we don't raise the warning in those estimators".
|
No other comment |
|
ok changed the comment. |
ogrisel
added a commit
that referenced
this pull request
Jul 28, 2013
[MRG] Fix tests on master, better input validation.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
much better input validation, test that warning is raised on (n_samples,1) y
Let's wait for travis' opinion on this. I also want to add a whatsnew entry.