Skip to content

TST replace pytest.warns(None) in preprocessing/test_data.py #22938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2022
Merged

TST replace pytest.warns(None) in preprocessing/test_data.py #22938

merged 2 commits into from
Mar 24, 2022
+4 −4

Conversation

danifernandes-hub
Copy link
Contributor

Reference Issues/PRs

Addresses #22572

What does this implement/fix? Explain your changes.

  • Replace pytest.warns(None) with warnings.catch_warnings()

thomasjpfan
thomasjpfan approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! From the commit that added these test: 04078be I agree these were checking for UserWarnings.

@thomasjpfan thomasjpfan added No Changelog Needed Quick Review For PRs that are quick to review and removed No Changelog Needed labels Mar 24, 2022
jeremiedbb
jeremiedbb approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danifernandes-hub

@jeremiedbb jeremiedbb merged commit 14a4934 into scikit-learn:main Mar 24, 2022
@thomasjpfan thomasjpfan mentioned this pull request Mar 26, 2022
Closed
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@danifernandes-hub @glemaitre
TST removed pytest.warns(None) in test_data.py (scikit-learn#22938)
1a8c291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:preprocessing No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danifernandes-hub @thomasjpfan @jeremiedbb