Skip to content

Conversation

henrymooresc
Copy link
Contributor

@henrymooresc henrymooresc commented Apr 5, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Ensures that sklearn.feature_extration.image.grid_to_graph passes numpydoc validation.

Changes:

  • Removed sklearn.feature_extration.image.grid_to_graph from FUNCTION_DOCSTRING_IGNORE_LIST.
  • Added "." to the end of multiple lines.
  • Added a Returns section

Any other comments?

I wasn't sure what to actually put in the Returns section since I am new to this. I just put what was mentioned above it under the return_as description.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @henrymooresc

@jeremiedbb jeremiedbb merged commit d0c53f7 into scikit-learn:main Apr 7, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
@henrymooresc henrymooresc deleted the my_feature branch April 29, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants