TST Remove pytest.warns(None) and replace it with warnings.catch_warnings in test_pipeline.py #23089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Apr 9, 2022
There was a problem hiding this comment.
Thank you for the PR!
For future reviewers: From the PR that added this check: #9716, I think this check was to catch a deprecation warning in 0.18 that is no longer in the library.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…o/scikit-learn into replace_warning_syntax
thomasjpfan
reviewed
Apr 9, 2022
sklearn/tests/test_pipeline.py
Outdated
| @@ -8,6 +8,7 @@ | |||
| import itertools | |||
|
|
|||
| import pytest | |||
| import warnings | |||
There was a problem hiding this comment.
Suggested change
| import warnings |
There was a problem hiding this comment.
Thanks. Have fixed this error.
thomasjpfan
approved these changes
Apr 9, 2022
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #22572
What does this implement/fix? Explain your changes.
Replaces deprecated pytest.warns(None) in test_pipeline.py with a warnings.catch_warnings() context handler.
Any other comments?
・Replaced all deprecated pytest.warns(None) in test.pipeline.py.
・I think the original code checks if it raises a UserWarning, please correct me if I am wrong.