Skip to content

TST: replace pytest.warns(None) in test_plot_partial_dependence.py #23114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iasoon
Copy link
Contributor

@iasoon iasoon commented Apr 11, 2022

Reference Issues/PRs

Related to #22572

What does this implement/fix? Explain your changes.

replaces pytest.warns(None) with warnings.catch_warnings(record=True) in test_plot_partial_dependence.py

Any other comments?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@ogrisel
Copy link
Member

ogrisel commented Apr 13, 2022

The windows failure is unrelated and already tracked in #23014.

@ogrisel ogrisel merged commit 426be18 into scikit-learn:main Apr 13, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants