TST make test_ridge_regression_hstacked_X more lenient #23170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_ridge_regression_hstacked_X
test_ridge_regression_hstacked_X
|
Hmmm it looks like the test fails in my last commit so:
|
|
For this failure, the elements have approx the same magnitude. Maybe this test needs the tol for ridge to be adjusted for sag like it was done in #23017 |
test_ridge_regression_hstacked_X
I probably found the source of the non determinism between CI runs #23181 |
test_ridge_regression_hstacked_X
jeremiedbb
approved these changes
Apr 21, 2022
jeremiedbb
reviewed
Apr 21, 2022
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…23170) Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23169, trying a similar approach to #23152