MNT Refactor splitter flow by removing indentation #23237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
commented
Apr 29, 2022
There was a problem hiding this comment.
Maybe @adrinjalali would be interested in this. It's a non-functional change. (I'm trying to get a to point where missing values for trees is easier to introduce).
| @@ -345,75 +345,77 @@ cdef class BestSplitter(BaseDenseSplitter): | |||
| features[n_drawn_constants], features[f_j] = features[f_j], features[n_drawn_constants] | |||
|
|
|||
| n_drawn_constants += 1 | |||
| continue | |||
There was a problem hiding this comment.
Most of this PR is adding continue in a few places, so there is less indentations from the else clause.
jjerphan
approved these changes
Apr 29, 2022
lesteve
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
LGTM, it may help (although sometimes diff is a bit weird) to look at the diff hiding white space:
https://github.com/scikit-learn/scikit-learn/pull/23237/files?w=1
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR is continues my other PRs for tree refactoring. (#22328, #22921, #22868)
What does this implement/fix? Explain your changes.
There is no functional change here. I think having less indentations makes the code over all easier to follow.
CC @jjerphan @glemaitre