Skip to content

[MRG] Missing contributions #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2013
Merged

Conversation

@@ -188,7 +188,11 @@ Changelog
- New website design and navigation by `Gilles Louppe`_, `Nelle Varoquaux`_,
Vincent Michael and `Andreas Müller`_.

- Improved documentation on :ref:`multi-class, multi-label and multi-output
classification <multiclass>` by Yannick Schwartz and `Arnaud Joly`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to Yannick's page: https://team.inria.fr/parietal/schwarty/ or maybe https://github.com/schwarty . @schwarty which one do you prefer?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogrisel my inria webpage. Thanks!

@ogrisel
Copy link
Member

ogrisel commented Jul 29, 2013

Apparently there is a conflict with the current master also.

@kmike
Copy link
Contributor

kmike commented Jul 29, 2013

Hi guys!

It seems that my contributions (most of them happened in 0.14 timeframe) are missing in whats_new, mainly #1828 which made HMMs several times faster. I know that HMMs fell out of favour, but my vanity doesn't let me stay silent :)

@arjoly
Copy link
Member Author

arjoly commented Jul 29, 2013

@kmike Ok, I will add your contribution :-)

@ogrisel
Copy link
Member

ogrisel commented Jul 29, 2013

@kmike please feel free to send a PR to add a summary of you contribution.

@ogrisel
Copy link
Member

ogrisel commented Jul 29, 2013

I had not seen @arjoly's reply, please ignore my last comment.

@arjoly
Copy link
Member Author

arjoly commented Jul 29, 2013

@ogrisel Rebase on top of master and add @kmike contribution.

@ogrisel
Copy link
Member

ogrisel commented Jul 29, 2013

LGTM.

@kmike
Copy link
Contributor

kmike commented Jul 29, 2013

Thanks for feeding my ego!

@GaelVaroquaux
Copy link
Member

👍 for merge + cherry pick in 0.14.X branch. Thank you to all of you.

NelleV added a commit that referenced this pull request Jul 29, 2013
@NelleV NelleV merged commit 855a753 into scikit-learn:master Jul 29, 2013
@arjoly arjoly deleted the missing-contributions branch July 29, 2013 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants