Skip to content

MNT Removes pytest.warns(None) in test_validation #23282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2022
Merged

MNT Removes pytest.warns(None) in test_validation #23282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17c8da7
MNT Removes pytest.warns(None) in test_validation
thomasjpfan May 4, 2022
4d023bb
REV Removes diff
thomasjpfan May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions sklearn/utils/tests/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,15 +1286,20 @@ def test_check_psd_eigenvalues_valid(

if not enable_warnings:
w_type = None
w_msg = ""

with pytest.warns(w_type, match=w_msg) as w:
assert_array_equal(
_check_psd_eigenvalues(lambdas, enable_warnings=enable_warnings),
expected_lambdas,
)
if w_type is None:
assert not w
with warnings.catch_warnings():
warnings.simplefilter("error", PositiveSpectrumWarning)
lambdas_fixed = _check_psd_eigenvalues(
lambdas, enable_warnings=enable_warnings
)
else:
with pytest.warns(w_type, match=w_msg):
lambdas_fixed = _check_psd_eigenvalues(
lambdas, enable_warnings=enable_warnings
)

assert_allclose(expected_lambdas, lambdas_fixed)


_psd_cases_invalid = {
Expand Down