Skip to content

Conversation

RMeli
Copy link
Contributor

@RMeli RMeli commented May 8, 2022

Reference Issues/PRs

Addresses #23295 (sklearn/_isotonic.pyx)

What does this implement/fix? Explain your changes.

Change np to cnp to reference NumPy's C API according to issue #23295 for sklearn/_isotonic.pyx.

@github-actions github-actions bot added the cython label May 8, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan changed the title MNT Use cimport numpy as cnp in Cython files for NumPy C API for sklearn/_isotonic.pyx MNT Use cimport numpy as cnp in _isotonic.pyx May 9, 2022
@thomasjpfan thomasjpfan merged commit 2303c89 into scikit-learn:main May 9, 2022
@RMeli RMeli deleted the 23295-isotonic branch May 9, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants