Skip to content

DOC Improved clarity, consistency and formatting for fastica/FastICA docstrings #23309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2022

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented May 8, 2022

Reference Issues/PRs

#22527 (comment)

What does this implement/fix? Explain your changes.

Improves docstrings for fastica and FastICA in decomposition/_fastica.py

Any other comments?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@Micky774 Micky774 changed the title Improved clarity, consistency and formatting for fastica/FastICA docstrings DOC Improved clarity, consistency and formatting for fastica/FastICA docstrings May 12, 2022
@Micky774
Copy link
Contributor Author

Also, I don't believe this requires any changelog entry.

@thomasjpfan thomasjpfan added No Changelog Needed Quick Review For PRs that are quick to review labels May 22, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Micky774.

@lorentzenchr lorentzenchr merged commit 7443071 into scikit-learn:main May 23, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
…CA` docstrings (scikit-learn#23309)

* Improved clarity, consistency and formatting for FastICA docstrings

* Updated wording
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
…CA` docstrings (#23309)

* Improved clarity, consistency and formatting for FastICA docstrings

* Updated wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants