ENH allow all main top level methods to have a corresponding set metadata request #23342
+85
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
glemaitre
reviewed
Jun 3, 2022
| def test_method_generation(): | ||
| # Test if all required request methods are generated. | ||
|
|
||
| class SimpleEstimator(BaseEstimator): |
There was a problem hiding this comment.
I am wondering if we could move this estimator in sklearn.utils._testing next to the Minimal* estimator and test it.
There was a problem hiding this comment.
I think after this PR we can slowly figure out what the common test estimators are and move them there. They have evolved quite a bit over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing top level methods to the list of methods which can have their own
set_{method}_request.This is the result of our discussions in #22988
Fixes #22988