Skip to content

MNT Minor refactor of n_support #23353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 30, 2022
Merged

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented May 12, 2022

Reference Issues/PRs

Related to #22898
Addresses #14788

What does this implement/fix? Explain your changes.

Performs a minor refactor of n_support test for one-class/regression style SVM estimators, and updated doc for regression style SVM estimators.

Any other comments?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label May 24, 2022
@Micky774 Micky774 changed the title MAINT Minor refactor of n_support MNT Minor refactor of n_support May 25, 2022
@ogrisel ogrisel merged commit fc2c0da into scikit-learn:main May 30, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants