TST Ensure that sklearn/cluster/tests/test_k_means.py is seed insensitive #23388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_kmeans_elkan_results test_kmeans_convergence test_minibatch_update_consistency test_fortran_aligned_data test_minibatch_sensible_reassign test_minibatch_reassign test_score_max_iter test_dense_sparse test_transform test_fit_transform test_n_init test_k_means_function test_float_precision test_weighted_vs_repeated test_unit_weights_vs_no_weights test_scaled_weights test_result_equal_in_diff_n_threads test_k_means_1_iteration test_euclidean_distance test_inertia test_kmeans_plusplus_output test_kmeans_plusplus_dataorder
jeremiedbb
approved these changes
Sep 25, 2022
There was a problem hiding this comment.
Thanks for the PR @ShoaibKhan. I synced with main and fixed the linting issues. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #22827
What does this implement/fix? Explain your changes.
This upgrades the k_means tests to account for greater randomness using global_random_seed.
Any other comments?
Some tests were left unchanged, as suggested in the original issue, as they don't test mathematical properties. Many tests failed with the introduction of randomness and to fix this, they were left as is.