Skip to content

DOC Move 23299 what's new for 1.1.1 #23399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022

Conversation

jeremiedbb
Copy link
Member

Fixes #23393

The fix for #23393 is already in main but was not released in 1.1.1. We should not wait 1.2 to release it. All we have to do is move the what's new to be sure to include it when we release 1.1.1.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I marked #23299 for 1.1.1 release and to backport it.

@thomasjpfan thomasjpfan changed the title Move 23299 what's new for 1.1.1 DOC Move 23299 what's new for 1.1.1 May 17, 2022
@thomasjpfan thomasjpfan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 17, 2022
@thomasjpfan thomasjpfan added this to the 1.1.1 milestone May 17, 2022
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel
Copy link
Member

ogrisel commented May 18, 2022

@thomasjpfan next time feel free to merge this kind of small maintenance doc fixes without waiting for a second review.

@ogrisel ogrisel merged commit c9e6abd into scikit-learn:main May 18, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request May 19, 2022
lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request May 19, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre added a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError raised when using pandas DataFrame in SelectFromModel.fit()
3 participants