CI Use lock files for CircleCI doc builds #23429
Conversation
|
The full doc build succeeded see here |
| # are using them for our min-dependencies doc generation. See | ||
| # https://www.anaconda.com/why-we-removed-the-free-channel-in-conda-4-7/ for | ||
| # more details. | ||
| if [[ "$CIRCLE_JOB" == "doc-min-dependencies" ]]; then |
There was a problem hiding this comment.
This is from a while ago and only made sense when we were using the defaults channel (now using conda-forge) so I removed this
| @@ -15,7 +15,7 @@ | |||
| import warnings | |||
| import re | |||
| from datetime import datetime | |||
| from packaging.version import parse | |||
There was a problem hiding this comment.
packaging was installed in the environment, this is not needed since we are vendoring packaging
| "numpydoc", | ||
| "sphinx-prompt", | ||
| ], | ||
| # scikit-image min version (0.14.3) not available through conda-forge |
There was a problem hiding this comment.
Can we bump scikit-image to 0.16.2, which has a version on conda-forge for py38?
From scikit-image's pypi release history, 0.14.3 was released on 6/11/19, and 0.16.2 was on 10/22/19. Our min supported numpy 1.17.3 was released on 10/17/19.
|
I updated the min scikit-image version to 0.16.2. Both full doc builds succeeded: doc and doc-min-dependencies I'll fix the errors in the next commit (wrong version in README.rst). |
Part of #22425