Skip to content

DOC Implement documentation suggestions pairwise distance #23431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RobertHGit
Copy link
Contributor

Reference Issues/PRs

Fixes #23430

What does this implement/fix? Explain your changes.

This fixes the docstring of the `pairwise_distance function in line with the desired changes listed in the issue.

Any other comments?

First time commit to scikit-learn.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan changed the title Implement documentation suggestions pairwise distance DOC Implement documentation suggestions pairwise distance May 21, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

LGTM

@thomasjpfan thomasjpfan merged commit 846a9d6 into scikit-learn:main May 21, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The location of distance_metrics() is wrong in this documentation snippet.
2 participants