-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT Centralize conda-lock version into min_dependencies.py #23432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
extra: [] | ||
for extra in ["build", "install", "docs", "examples", "tests", "benchmark"] | ||
} | ||
tag_to_packages: dict = defaultdict(list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it easier to add new entries, such as "maintenance" .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I agree that it's nicer to have a single place where the conda-lock version is defined. I have to say I would slightly prefer to have Do you have a use case in mind where it is useful to have this in |
I prefer to have all the versions in a centralized place. Placing it all in
I think a simple use case is for |
OK, this makes sense, merging this one! I do find it a bit weird in the sense that the conda-lock version is not really a |
Reference Issues/PRs
Related to #22425
What does this implement/fix? Explain your changes.
This PR moves the pinned version of
conda-lock
intomin_dependencies.py
and grabs the version from there.WDYT @lesteve ?