Skip to content

DOC Ensures that sklearn.metrics._ranking.auc passes numpydoc validation #23433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 20, 2022

Conversation

boraxpr
Copy link
Contributor

@boraxpr boraxpr commented May 20, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

  1. PR08 : Line 58 : Description should start with a capital letter.
  2. PR08 : Line 61 : Description should start with a capital letter.
  3. RT03 : Line 66 : Add a description to auc; Area Under the Curve return section.

Any other comments?

boraxpr and others added 8 commits May 17, 2022 20:39
Remove "sklearn.feature_extraction.image.img_to_graph" from sklearn.tests.test_docstrings.py FUNCTION_DOCSTRING_IGNORE_LIST
line 142: SS03 : Summary does not end with a period.
line 161: PR09 : Param "dtype" desc. should finish with "."
line 163: RT01 : No Returns section Found.
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Remove "sklearn.metrics._ranking.auc" from sklearn.tests.test_docstrings.py FUNCTION_DOCSTRING_IGNORE_LIST
line 58: PR08 : Description should start with a capital letter.
line 61: PR08 : Description should start with a capital letter.
line 66: RT03: Add a description to auc; Area Under the Curve return section.
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

LGTM

@thomasjpfan thomasjpfan merged commit f5871a3 into scikit-learn:main May 20, 2022
@thomasjpfan
Copy link
Member

I noticed you are using the main branch on your fork. I recommend using a feature branch for development. You can find out more details in How to contribute step 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants