MAINT Remove commented dissimilarities #23457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
May 25, 2022
ArturoAmorQ
approved these changes
May 25, 2022
jeremiedbb
approved these changes
May 25, 2022
There was a problem hiding this comment.
Thanks @jjerphan. Here's a maintainability award 🏆 for you 😄
This mostly was a simplification to make the other PR shorter / easier to review. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Precedes #22764
What does this implement/fix? Explain your changes.
This removes old implementations of dissimilarities which were implemented as
DistanceMetricsbut which were actually not distance metrics.