[MRG] TST use global_random_seed in sklearn/ensemble/tests/test_gradient_boosting.py #23549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for @glemaitre 's comments. I have added them and re-checked if other tests needs to use global_random_seed. |
test_classification_toy test_classification_synthetic test_regression_dataset test_iris test_regression_synthetic test_probability_log test_max_feature_regression test_staged_functions_defensive test_quantile_loss test_warm_start test_warm_start_n_estimators test_warm_start_fortran test_zero_estimator_reg test_zero_estimator_clf test_probability_exponential
test_classification_toy test_classification_synthetic test_regression_dataset test_iris test_regression_synthetic test_probability_log test_max_feature_regression test_staged_functions_defensive test_quantile_loss test_warm_start test_warm_start_n_estimators test_warm_start_fortran test_zero_estimator_reg test_zero_estimator_clf test_probability_exponential
test_classification_toy test_classification_synthetic test_regression_dataset test_iris test_regression_synthetic test_probability_log test_max_feature_regression test_staged_functions_defensive test_quantile_loss test_warm_start test_warm_start_n_estimators test_warm_start_fortran test_zero_estimator_reg test_zero_estimator_clf test_probability_exponential
jeremiedbb
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #22827
What does this implement/fix? Explain your changes.
test_staged_functions_defensiveandtest_gradient_boosting_with_initto useglobal_random_seed.Any other comments?
There is another place that uses
np.random.RandomState(0)in line 52. It was used to permute Iris dataset.I think it does not need to use
global_random_seedsince it was fixed to 0.And it seems that it won't be affected by the env variable.