-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
feat: add support for Remote Cloud Development with Gitpod #23556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Learn more about this file at 'https://www.gitpod.io/docs/references/gitpod-yml'
I would have appreciated that you clearly disclosed that you are currently working for Gitpod in the description of this PR. I see that you have opened similar PRs in other projects. I would personally give a very similar answer to the Ansible maintainer in ansible/ansible#77942 (comment): this is not something I am keen on maintaining going forward. More than happy to hear other maintainers opinion about this one! |
Yeah, forgot to mention that with current PR template. Updated it now, sorry for that.
I respect your opinion, but, this |
I have done the initial work for adding GitPod support to NumPy. The NumPy config runs on a For us to introduce GitPod, there is some documentation work to be done. For example, NumPy has a whole page on using GitPod, and they have a FAQ describing common problems. The biggest benefit I see for this is for running sprints, where we do not need to spend the first hour debugging development environments. For normal development, I think it's good to have users go through the process of installing and testing on different platforms. This helps keep our install instructions up to date for different platforms and helps with debugging for a specific platform. Overall I am -0.25 for adding GitPod for scikit-learn. In general, GitPod does make it easier to contribute, but there is a balance of contributor time and maintainer time. A maintainer needs to maintain the code and docs related to |
I tried to open a VS Code session by clicking on the badge of the description of the PR, and the VS Code terminal has the following error message by default:
Also the VS Code obtained is missing all the useful extensions (e.g. Python tools, Cython syntax highlighting...). It's probably because we would need to inform vs code to activate the I share the same feeling as @thomasjpfan and @lesteve in terms of maintenance. Maybe someone would like to volunteer to maintain a well documented gitpod config for scikit-learn in a side repo. If it works well out of the box for first time contributors at sprints, then we might decide to make this more official and move such a repo under the https://github.com/scikit-learn/ organization later. But I am also -0.25 to maintain the doc of a gitpod deployment in the main scikit-learn documentation, at least in the short term. |
- init: | | ||
python3 -m venv sklearn-env | ||
source sklearn-env/bin/activate | ||
pip3 install wheel numpy scipy cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have activated the venv, it would make sense to use the pip command directly for consistency with the next line.
pip3 install wheel numpy scipy cython | |
pip install wheel numpy scipy cython pandas matplotlib |
I also added pandas and matplotlib that are used in many examples.
@Siddhant-K-code I get the following error: ` HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
During handling of the above exception, another exception occurred: Traceback (most recent call last): Contents of /workspace/scikit-learn/sklearn/__check_build: It seems that scikit-learn has not been built correctly. If you have installed scikit-learn from source, please do not forget If you have used an installer, please check that it is suited for your |
👋🏼 Hello, Siddhant here from Gitpod
Reference Issues/PRs
N/A
What does this implement/fix? Explain your changes.
Problem: It would skip all the pain in running the manual steps for setup & building from the source, running all the manual commands with Hardware limitations.
Solution: it Contains a
.gitpod.yml
file which runs all the necessary commands (docs) required to create a ready to code environment on Gitpod. It would help contributors to directly jump into the main part without doing the manually running the Installation commands.Any other comments?
To Test it out, Just Click on following button & see the preview: