MAINT validate parameter in VarianceThreshold #23581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove variance threshold from to be validated
Add parameter validation for variance threshold.
jeremiedbb
reviewed
Jun 10, 2022
There was a problem hiding this comment.
Thanks for the PR @SangamSwadiK. You can now remove the validation on line 118 elif self.threshold < 0.0:, and the corresponding test test_variance_negative in test_variance_threshold.py
|
All good. Merging. Thanks @SangamSwadiK |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Sangam Swadi K <sangamswadik@users.noreply.github.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Issue: #23462 validating estimator params
What does this implement/fix? Explain your changes.
Any other comments?
Please let me know if I missed something/did it incorrectly, ill fix it asap.