Skip to content

[MRG] Enable multi-output voting regression #23603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

wullli
Copy link

@wullli wullli commented Jun 13, 2022

Reference Issues/PRs

Partially fixes #18289.

What does this implement/fix? Explain your changes.

Enables multi-output regression with VotingRegressor.

Any other comments?

I am aware that another PR exists in regards to this (#19223), but it seems to be stale and I think the regression part is quite a simple fix, which is why I created this PR.

@wullli
Copy link
Author

wullli commented Jun 13, 2022

Do you think I need a change-log entry for this?

@wullli wullli changed the title Enable multi-output voting regression [WIP] Enable multi-output voting regression Jun 15, 2022
@ClaudiaASoares
Copy link

Any news on the status of this PR?

Copy link

github-actions bot commented May 2, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fc880de. Link to the linter CI: here

@wullli wullli force-pushed the fix_multi_voting_regression branch from 946fa5d to 607dd40 Compare May 2, 2024 14:46
@wullli wullli marked this pull request as draft May 2, 2024 16:05
@wullli wullli changed the title [WIP] Enable multi-output voting regression [MRG] Enable multi-output voting regression May 2, 2024
@wullli wullli marked this pull request as ready for review May 2, 2024 16:07
@wullli
Copy link
Author

wullli commented May 2, 2024

The failing pipeline scikit-learn.scikit-learn seems to be completely unrelated to my changes, so not sure why it fails. Let me know if I can do anything about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multioutput in VotingClassifier and VotingRegressor
2 participants