MAINT remove deprecated sym_pos arguments in scipy.linalg.solve #23617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we have a huge number of failures, I think that we could break down the problem because some deprecations are not simple. |
|
I think the scipy deprecation changes should definitely be merged. The pandas one, I really haven't managed to understand what they want to do and whether the warning we get is the intended behaviour, so I would leave that for another PR ... |
This reverts commit 3fcea30.
|
I reverted the pandas changes to keep only the sym_pos ones, let's merge this one! |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
glemaitre
added a commit
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some of the deprecation warnings shown in #23614
xref #23626
sym_pos=Truein scipy solve DEP: add actual DeprecationWarning for sym_pos-keyword of scipy.linalg.solve scipy/scipy#15821. This was actually shown as deprecated for a while in the documentation (ENH: Integrating LAPACK "expert" routines with conditioning warnings for linalg.solve_ family scipy/scipy#6775)df.iloc[:, i] = newvals. DEPR: df.iloc[:, foo] = bar attempt to set inplace pandas-dev/pandas#45333