Skip to content

MAINT validate parameters in DummyRegressor and DummyClassifier #23645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 28, 2022
Merged

MAINT validate parameters in DummyRegressor and DummyClassifier #23645

merged 12 commits into from
Jun 28, 2022

Conversation

Nwanna-Joseph
Copy link
Contributor

Reference Issues/PRs

See PR #23462

What does this implement/fix? Explain your changes.

Add validators for DummyClassifier and DummyRegressor. Towards #23462

Any other comments?

@glemaitre glemaitre added Validation related to input validation No Changelog Needed labels Jun 16, 2022
@Jitensid Jitensid mentioned this pull request Jun 24, 2022
Closed
@glemaitre glemaitre changed the title [MRG] Use _validate_params in DummyRegressor and DummyClassifier MAINT validate parameters in DummyRegressor and DummyClassifier Jun 27, 2022
@glemaitre glemaitre self-requested a review June 27, 2022 09:28
glemaitre
glemaitre approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes since there is some collateral failures in successive halving tests.

@Nwanna-Joseph
Copy link
Contributor Author

I pushed some changes since there is some collateral failures in successive halving tests.

Thanks.

@glemaitre glemaitre reopened this Jun 27, 2022
@glemaitre
Copy link
Member

@Nwanna-Joseph do not close the PR until someone else validates it and merges it.
We have currently a single approval.

@Nwanna-Joseph
Copy link
Contributor Author

Mistakenly closed this. Reopening.

@Nwanna-Joseph
Copy link
Contributor Author

@Nwanna-Joseph do not close the PR until someone else validates it and merges it. We have currently a single approval.

Thanks. That was a mistake. Quick typing.

jeremiedbb
jeremiedbb approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Nwanna-Joseph.

@jeremiedbb jeremiedbb merged commit f5e02df into scikit-learn:main Jun 28, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
@Nwanna-Joseph @glemaitre
@jeremiedbb @ogrisel
MAINT validate parameters in DummyRegressor and DummyClassifier (scik…
7c0e53c 
…it-learn#23645)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
No Changelog Needed Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nwanna-Joseph @glemaitre @jeremiedbb