Skip to content

DOC fix link to reference in Skewed Chi Squared Kernel #23713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022
Merged

DOC fix link to reference in Skewed Chi Squared Kernel #23713

merged 1 commit into from
Jun 21, 2022

Conversation

kanissh
Copy link
Contributor

@kanissh kanissh commented Jun 21, 2022

Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"

Reference Issues/PRs

#23631

What does this implement/fix? Explain your changes.

Link to “Random Fourier approximations for skewed multiplicative histogram kernels” changed from https://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.227.1802&rep=rep1&type=pdf to https://www.researchgate.net/publication/221114584_Random_Fourier_Approximations_for_Skewed_Multiplicative_Histogram_Kernels

Any other comments?

Doi of the article leads to this site https://link.springer.com/chapter/10.1007/978-3-642-15986-2_27 but it is under a paywall. The article in ResearchGate has a downloadable full-text pdf.

Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"
@lesteve
Copy link
Member

lesteve commented Jun 21, 2022

Thanks a lot merging!

@lesteve lesteve merged commit 55dfde5 into scikit-learn:main Jun 21, 2022
@kanissh kanissh deleted the doc-skewed-chi-squared-kernel-#23631 branch June 21, 2022 16:38
@kanissh
Copy link
Contributor Author

kanissh commented Jun 23, 2022

@lesteve The replacement link changed is from researchgate. There are other broken links in the original issue which are also form researchgate. All of them have the similar pattern of error and all are accessible by the browser.

I was wondering whether this new link might also cause such a problem. Can you please verify?

@lesteve
Copy link
Member

lesteve commented Jun 23, 2022

researchgate are flagged as broken by make linkcheck but the work-around is to add them to linkcheck_ignore see #23737 (comment) for more details.

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Updated link to reference "Random Fourier approximations for skewed multiplicative histogram kernels"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants