DEPR deprecate n_iter in MiniBatchSparsePCA #23726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Jun 22, 2022
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
|
I also move the deprecation warning raise in |
jeremiedbb
reviewed
Jun 22, 2022
test_spca_early_stopping
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
ogrisel
reviewed
Jun 24, 2022
| To disable convergence detection based on cost function, set | ||
| `max_no_improvement` to `None`. | ||
|
|
||
| .. versionadded:: 1.1 |
There was a problem hiding this comment.
In retrospect it's a bit weird to introduce a new parameter in a bugfix release.
Maybe we should instead move this PR to target 1.2 and update the previous deprecation message for the MB sparse PCA to 1.4 instead of 1.3 so that both the MB dict learning and sparse PCA variant are actually removed in 1.4 at the same time to ease maintenance.
ogrisel
added a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is deprecating
n_iterand introducingmax_iter,tol, andmax_no_improvementparameters to be consistent withMiniBatchDictionaryLearning.We should do this step in version 1.1 since some code will have to be removed and
n_iterwould not be available inMiniBatchDictionaryLearningrequired by theMiniBatchSparsePCA.We should therefore backport this fix in 1.1.2.