Skip to content

MAINT add link to Bishop book as falsely broken hyperlink #23761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

MAINT add link to Bishop book as falsely broken hyperlink #23761

merged 3 commits into from
Jun 27, 2022

Conversation

kensac
Copy link
Contributor

@kensac kensac commented Jun 27, 2022

Reference Issues/PRs
Towards #23631

This link is working in a browser, it should be addded to linkcheck_ignore similarly to what was done in #23737 https://www.microsoft.com/en-us/research/uploads/prod/2006/01/Bishop-Pattern-Recognition-and-Machine-Learning-2006.pdf modules/svm.rst

HTTPSConnectionPool(host='www.microsoft.com', port=443): Read timed out. (read timeout=10)

What does this implement/fix? Explain your changes.
The link https://www.microsoft.com/en-us/research/uploads/prod/2006/01/Bishop-Pattern-Recognition-and-Machine-Learning-2006.pdf opens the document in the browser. Added the link to linkcheck_ignore

Any other comments?
None

kensac and others added 3 commits June 27, 2022 11:21
Reference Issues/PRs
Towards #23631 

What does this implement/fix? Explain your changes.
The link https://www.microsoft.com/en-us/research/uploads/prod/2006/01/Bishop-Pattern-Recognition-and-Machine-Learning-2006.pdf opens the document in the browser. Added the link to linkcheck_ignore

Any other comments?
None
Reference Issues/PRs
Towards #23631
Fixed Linting of the previous commit
@glemaitre glemaitre changed the title Included link in linkcheck_ignore MAINT add link to Bishop book as falsely broken hyperlink Jun 27, 2022
@glemaitre
Copy link
Member

I just move the link in the section on false detections.
Merging. Thanks @kensac

@glemaitre glemaitre merged commit 5e61213 into scikit-learn:main Jun 27, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
…rn#23761)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
…rn#23761)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Aug 5, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants