Param validation for Dictvectorizer #23820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micky774
reviewed
Jul 4, 2022
jeremiedbb
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Thanks for the PR @SangamSwadiK. You forgot to remove the estimator from the common test blacklist :)
Please also call _validate_params in fit_transform.
| @@ -97,6 +97,13 @@ class DictVectorizer(TransformerMixin, BaseEstimator): | |||
| array([[0., 0., 4.]]) | |||
| """ | |||
|
|
|||
| _parameter_constraints = { | |||
| "dtype": [type], # TODO: TypeOptions constraint, | |||
There was a problem hiding this comment.
When any dtype is valid, we'd rather delegate validation to numpy since dtype can be exressed in many different ways, as discussed in #23579
Suggested change
| "dtype": [type], # TODO: TypeOptions constraint, | |
| "dtype": "no_validation" # validation delegated to numpy |
|
@Micky774 does this PR has your +1 now ? |
Yes, looks good now, +1. |
|
Merging. Thanks @SangamSwadiK for the PR and @Micky774 for the review. |
Harsh14901
pushed a commit
to Harsh14901/scikit-learn
that referenced
this pull request
Jul 6, 2022
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Issue: #23462 (make estimators use _validate_params)
What does this implement/fix? Explain your changes.
Adds parameter validation to DictVectorizer.
Any other comments?
Added #Todo for parameter dtype