CI Set MACOSX_DEPLOYMENT_TARGET=10.9 #23833
Conversation
|
I'll put this on milestone 1.2. I think setting |
There was a problem hiding this comment.
Thank you for solving this issue, @thomasjpfan.
I am OK with this change, but I think the (reasons for the) support for older version of OS X must be documented in the change-log and above this script export. What do you think?
I do not have a great reason to build for 10.9 besides it's not more work for us. The original reason the min version was bumped up from 10.9 to 10.13 was because the openmp we were using was built with 10.13. The one from conda-forge is built with 10.9 so we can go back to 10.9. As noted in #23830, this fix did not work, but I can not really debug what went wrong without a 10.12 system. For me, I am +0.4 on moving the version back down. |
|
We have another issue regarding old versions of OSX: #24113 Since there is user demand, I think we should build with OSX 10.9 as the minimum version. @glemaitre Do you think this should a part of 1.1.2? |
|
I assume because the wheels are broken right now. |
|
Okay, I added this PR to the 1.1.2 changelog as a bug fix. |
Reference Issues/PRs
Fixes #23830
Fixes #24113
What does this implement/fix? Explain your changes.
For conda-forge, their llvm-openmp uses MACOSX_DEPLOYMENT_TARGET=10.9:
https://github.com/conda-forge/openmp-feedstock/blob/1b7c7da892528e2e17a51c449d41e1ba54cc16f2/.ci_support/osx_64_.yaml
This means we can set the same target and support older version of OSX.