Skip to content

Conversation

stefmolin
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

sklearn.model_selection._validation.learning_curve already passed the numpydoc validation checks, but it was not being checked. This PR reenables the validation on this function.

Any other comments?

@stefmolin
Copy link
Contributor Author

Ping @adrinjalali

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a funny one lol

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the CI is green

@glemaitre glemaitre merged commit bd8e6be into scikit-learn:main Jul 16, 2022
@glemaitre
Copy link
Member

glemaitre commented Jul 16, 2022

Thanks @stefmolin

@stefmolin stefmolin deleted the doc/validation_learning_curve branch July 16, 2022 16:43
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants