Skip to content

Conversation

stefmolin
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Fixed blank lines and parameter order in docstring to ensure sklearn.model_selection._validation.permutation_test_score passes numpydoc validation

Any other comments?

@stefmolin
Copy link
Contributor Author

Ping @adrinjalali

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait to for the CIs to complete

@adrinjalali adrinjalali changed the title DOC: Ensure sklearn.model_selection._validation.permutation_test_score passes numpydoc validation DOC Ensure sklearn.model_selection._validation.permutation_test_score passes numpydoc validation Jul 16, 2022
@adrinjalali adrinjalali merged commit a81b359 into scikit-learn:main Jul 16, 2022
@adrinjalali
Copy link
Member

Been a very productive sprint day for you @stefmolin :)

@stefmolin stefmolin deleted the doc/validation_permutation_test branch July 16, 2022 16:43
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
… passes numpydoc validation (scikit-learn#23912)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Aug 5, 2022
… passes numpydoc validation (#23912)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants