FIX Fixes OrdinalEncoder.inverse_tranform nan encoded values #24087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Aug 4, 2022
Okay, I moved this to 1.1.2. |
|
I am taking a bit of liberty to merge this one without a second approval |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 5, 2022
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #24082
What does this implement/fix? Explain your changes.
This PR fixes
OrdinalEncoder.inverse_transformwhen either the encoded unknown values or encoded missing values isnan.