Skip to content

MAINT Parameters validation for SpectralEmbedding #24103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 31, 2022
Merged

MAINT Parameters validation for SpectralEmbedding #24103

merged 11 commits into from
Aug 31, 2022

Conversation

kasmith11
Copy link
Contributor

Reference Issues/PRs

References #23462 and #22722

What does this implement/fix? Explain your changes.

Adds _parameter_constraints for SpectralEmbedding

Any other comments?

The docstring for SpectralEmbedding contains a parameter eigen_tol while I believe the documentation does not? Let me know if I'm referencing the wrong version of the documentation.

@lucyleeow lucyleeow added the Validation related to input validation label Aug 4, 2022
@jjerphan jjerphan changed the title Towards #23462 - SpectralEmbedding MAINT Parameters validation for SpectralEmbedding Aug 4, 2022
@Micky774 Micky774 mentioned this pull request Aug 4, 2022
Closed
@Micky774
Copy link
Contributor

Micky774 commented Aug 5, 2022

The docstring for SpectralEmbedding contains a parameter eigen_tol while I believe the documentation does not? Let me know if I'm referencing the wrong version of the documentation.

eigen_tol will be officially released in 1.2. The updated docs can be seen here and will be available on release :)

@Micky774
Copy link
Contributor

Micky774 commented Aug 5, 2022

Also note that this PR contains changes to SplineTransformer which I believe are carried over from your other PR (#24057). When working on new, separate PRs, try to ensure that each have their changes made on a branch directly branching off from main to keep them independent. Please let me know if you have any questions or concerns :)

@glemaitre
Copy link
Member

@kasmith11 could you remove the changes related to the other PR where you modified the SplineTransformer.

Micky774
Micky774 reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@Micky774 Micky774 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny changes, otherwise looks good to me, thanks!

jeremiedbb
jeremiedbb approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kasmith11. I directly pushed to address the review comments and remove some old validation code.

LGTM.

@jeremiedbb jeremiedbb merged commit 5944077 into scikit-learn:main Aug 31, 2022
@kasmith11
Copy link
Contributor Author

Thank you. @jeremiedbb

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
@kasmith11 @jeremiedbb @glemaitre
MAINT Parameters validation for SpectralEmbedding (scikit-learn#24103)
b92f8cd 
Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micky774 Micky774 Micky774 left review comments

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:manifold module:preprocessing No Changelog Needed Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kasmith11 @Micky774 @glemaitre @jeremiedbb @jjerphan @lucyleeow