DOC Ensure _dict_learning.dict_learning passes numpydoc validation #24316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoAmorQ
reviewed
Sep 2, 2022
| MiniBatchSparsePCA | ||
| dict_learning_online : Solve a dictionary learning matrix factorization problem online. | ||
| DictionaryLearning : Find a dictionary that sparsely encodes data. | ||
| MiniBatchDictionaryLearning : A faster, less accurate version of the dictionary learning algorithm. |
There was a problem hiding this comment.
Suggested change
| MiniBatchDictionaryLearning : A faster, less accurate version of the dictionary learning algorithm. | |
| MiniBatchDictionaryLearning : A faster, less accurate version of the dictionary | |
| learning algorithm. |
Thanks for the PR @maikia! My guess is that the CI is failing due to the maximum line length convention.
|
thanks @ArturoAmorQ |
|
Thanks @maikia |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #21350
@adrinjalali
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?