Skip to content

Conversation

maikia
Copy link
Contributor

@maikia maikia commented Sep 2, 2022

towards #21350
There is an additional issue within the @sklearn.utils.deprecated decorator which updates the docstring against the numpydoc and will be fixed in other PR, issue: #24328

@glemaitre @ogrisel

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@maikia maikia changed the title Plot det curve doc DOC Ensure metrics._plot.det_curve.plot_det_curve passes numpydoc validation Sep 2, 2022
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@glemaitre glemaitre changed the title DOC Ensure metrics._plot.det_curve.plot_det_curve passes numpydoc validation DOC Ensure plot_det_curve passes numpydoc validation Sep 3, 2022
@glemaitre
Copy link
Member

Thanks @maikia Let's merge then.

@glemaitre glemaitre merged commit 37e2ffd into scikit-learn:main Sep 3, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants