DOC Update estimator representation example #24439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
|
We need as well to redirect the previous example to the new one by editing |
glemaitre
reviewed
Sep 15, 2022
| # In notebooks estimators and pipelines will use a rich HTML representation. | ||
| # This is particularly useful to summarise the | ||
| # structure of pipelines and other composite estimators, with interactivity to | ||
| # provide detail. Click on the example image below to expand Pipeline |
There was a problem hiding this comment.
It might be worth mentioning clicking on the "horizontal arrow" instead of the image.
There was a problem hiding this comment.
This is what the image looks like for me, you can click nearly anywhere on that image and something will happen. So I'd vote for leaving the text as is. In addition I took the text nearly verbatim from the "release highlights" section, so I guess someone already thought about this/if it was good enough then it probably is good enough now as well.
WDYT?
The compact representation is now the default and the HTML representation is less well known. This updates the example to reflect the new default and gives the HTML some more visibility.
9eeccfc to
2fa5ec2
Compare
|
OK Good enough then. Thanks @betatim Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #21289
What does this implement/fix? Explain your changes.
This updates the example that showed off the "compact" representation of estimators. The compact representation is now the default and the HTML representation is less well known. This updates the example to reflect the new default and gives the HTML some more visibility.
Any other comments?
What should we call this example? Once we have a good name/title I will update the filename to reflect that.