Skip to content

Conversation

mansi1597
Copy link
Contributor

@mansi1597 mansi1597 commented Oct 5, 2022

Reference Issues/PRs
Addresses #21350

What does this implement/fix? Explain your changes.
Adds valid function parameters description and adds valid return statement description.
Removed extra break lines.

Ensures sklearn.utils.extmath.svd_flip passes npdoc
Removed svd_flip from function doctring ignore list
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @mansi1597 !

mansi1597 and others added 2 commits October 11, 2022 13:30
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! LGTM

@thomasjpfan thomasjpfan changed the title Doc Ensures that sklearn.utils.extmath.svd_flip passes numpydoc validation DOC Ensures that sklearn.utils.extmath.svd_flip passes numpydoc validation Oct 11, 2022
@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.utils.extmath.svd_flip passes numpydoc validation DOC Ensures that svd_flip passes numpydoc validation Oct 11, 2022
@thomasjpfan thomasjpfan merged commit 97057d3 into scikit-learn:main Oct 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants