Skip to content

MAINT PairwiseDistancesReduction: Rename some symbols and files #24623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 13, 2022
Merged

MAINT PairwiseDistancesReduction: Rename some symbols and files #24623

merged 8 commits into from
Oct 13, 2022

Conversation

jjerphan
Copy link
Member

Reference Issues/PRs

Piece of #24542.

What does this implement/fix? Explain your changes.

Rename interfaces and files for consistency:

  • Base{DistanceReducer→DistancesReduction}
  • radius_{neighborhood→neighbors}

@jjerphan jjerphan mentioned this pull request Oct 10, 2022
Merged
@jjerphan jjerphan added Waiting for Reviewer Quick Review For PRs that are quick to review labels Oct 12, 2022
ogrisel
ogrisel approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit.

jjerphan and others added 2 commits October 13, 2022 09:13
@jjerphan @ogrisel @thomasjpfan
fixup! DOC Reword comments about float64 upcast
16437ff 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
thomasjpfan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan
Copy link
Member

There is merge conflict!

@jjerphan @ogrisel
Update sklearn/metrics/_pairwise_distances_reduction/_base.pyx.tp
c13c0a1 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@thomasjpfan thomasjpfan merged commit 5b45d1f into scikit-learn:main Oct 13, 2022
@jjerphan jjerphan deleted the maint/pdr-renamings branch October 13, 2022 17:17
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@jjerphan @ogrisel
@thomasjpfan @glemaitre
MAINT PairwiseDistancesReduction: Rename some symbols and files (sc…
ba8b09c 
…ikit-learn#24623)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
No Changelog Needed Quick Review For PRs that are quick to review Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjerphan @thomasjpfan @ogrisel