API Remove sklearn.metrics.manhattan_distances option sum_over_features
#24630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklearn.metrics.manhattan_distances option sum_over_features
jeremiedbb
reviewed
Oct 14, 2022
|
@jeremiedbb Thanks for the suggestions. Let me know if anything else is missing. |
ogrisel
approved these changes
Oct 14, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #24597.
What does this implement/fix? Explain your changes.
This PR deprecates
sum_over_featuresparameter insklearn.metrics.manhattan_distances.Launched:
and all tests pass with 0 warnings.
Also,
fails. I think it's due to one of the recent merges and is worth looking into.