MAINT Fix full doc build by avoiding plot_set_output.py side-effect #24654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Oct 13, 2022
| # %% | ||
| # This resets `transform_output` to its default value to avoid impacting other | ||
| # examples when generating the scikit-learn documentation | ||
| set_config(transform_output="default") |
There was a problem hiding this comment.
This is surprising to me. I thought the examples run in separate processes.
There was a problem hiding this comment.
As far as I know this is not the case: there is an exec somewhere that runs all the code from all the examples in the same interpreter. For example this is why sphinx-gallery has some reset functionality to clean-up before each example (e.g. closing all matplotlib figures): https://sphinx-gallery.github.io/stable/advanced.html#resetting-before-each-example
jjerphan
approved these changes
Oct 13, 2022
|
Another possibility would be to use the context manager where we would not have to comment. The downside is the extra indent. I am merging as-is to have the documentation running but we could come back to it if necessary. |
|
Thanks @lesteve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #24652 by avoiding setting
transform_outputto examples running afterplot_set_output.py