Skip to content

MAINT Clean deprecation for 1.2: default random_state in randomized_svd #24661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jeremiedbb
Copy link
Member

The default value of random_state in randomized_svd changes from 0 to None.

This PR should be the last of this series, I didn't find any deprecation left (until I find another one 😄)

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Oct 14, 2022
@jeremiedbb jeremiedbb added this to the 1.2 milestone Oct 14, 2022
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I guess this is like easter eggs hunts 🥚 : it's easier to find the big and obvious ones and there always be one that would will found in a obscure places a few months later. 🙃

@ogrisel ogrisel merged commit 96f0a01 into scikit-learn:main Oct 14, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants