Skip to content

EFF avoid computing inertia in KMeans' predict #24666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

EFF avoid computing inertia in KMeans' predict #24666

merged 1 commit into from
Oct 14, 2022

Conversation

jeremiedbb
Copy link
Member

inertia is not used by predict and we can easily avoid to compute it.

@jeremiedbb jeremiedbb added module:cluster Quick Review For PRs that are quick to review labels Oct 14, 2022
ogrisel
ogrisel approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I don't think we really need changelog entry for this but feel free to add one if you like.

thomasjpfan
thomasjpfan approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb
Copy link
Member Author

I don't think we really need changelog entry for this but feel free to add one if you like.

not worth :)

@jeremiedbb jeremiedbb merged commit 8610e14 into scikit-learn:main Oct 14, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@jeremiedbb @glemaitre
EFF avoid computing inertia in KMeans' predict (scikit-learn#24666)
7d5eda2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:cluster Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @ogrisel @thomasjpfan