Skip to content

FEA implement max precision@recall K / recall@precision K #24671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Kshitij68
Copy link
Contributor

@Kshitij68 Kshitij68 commented Oct 15, 2022

Reference Issues/PRs

This PR fixes #20266
A similar PR #20877 for this was opened long time back, but currently exists in stalled state.
Refering #21718 so this PR is also visible to people following that thread

What does this implement/fix? Explain your changes.

This PR adds two new metrics max_precision_at_recall_k & max_recall_at_precision_k.

Any other comments?

There were several comments under previous PR by @glemaitre . I've been able to resolve most of them, but I would like some clarifications about two points:-

@glemaitre glemaitre changed the title Feature - Add new metrics for Binary Classification. Resolves #20266 FEA implement max precision@recall K / recall@precision K Oct 17, 2022
@Kshitij68 Kshitij68 force-pushed the contribution/add-new-metrics branch from 5e7a204 to d61dd08 Compare October 17, 2022 18:05
@Kshitij68 Kshitij68 force-pushed the contribution/add-new-metrics branch from d61dd08 to 4fdcc68 Compare October 20, 2022 12:50
@lorentzenchr
Copy link
Member

@Kshitij68 Thanks for working on this feature. Please note the discussion for inclusion in the issue #20266.

@Kshitij68
Copy link
Contributor Author

@Kshitij68 Thanks for working on this feature. Please note the discussion for inclusion in the issue #20266.

Yes, I am following the issue. I'd still keep this PR open until a decision has been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision @ Recall K || Recall @ Precision K
2 participants