-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT Fix build when SKLEARN_OPENMP_PARALLELISM_ENABLED=False #24682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One thing I don't quite understand is that the "no OpenMP" build did not fail to compile with an unprotected For some reason it seems like
|
The "no OpenMP" build passed, the "Linux py38_conda_defaults_openblas" was a spurious one, triggering CI again to get it green. |
Looking at why we get OpenMP in the "no OpenMP" build:
|
The Linux py38 conda defaults openblas build issue is actually a genuine one. It is tracked in #24687 |
I created #24694 to track the fact that the "no OpenMP" build actually has OpenMP. |
LGTM. Thanks @lesteve |
…-learn#24682) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
The Pyodide build fails on the
main
branch, see in lesteve/scikit-learn-tests-pyodide#2 (comment)This is using the recommendation from https://scikit-learn.org/dev/developers/performance.html#using-openmp to protect
openmp
usage when it is disabled by settingSKLEARN_OPENMP_PARALLELISM_ENABLED=False