-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC fix deprecation warning raised by KMeans and Matplotlib #24692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The plots are now too close together so that the axis labels get cut off. Not quite sure what the replacement for |
I would try to use |
I also needed to create a single figure to have all the axes on it. But it should do the trick or at least it should be easy to setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do you know why the ax.set_position()
isn't needed anymore/removing it didn't seem to change anything?
Co-authored-by: Tim Head <betatim@gmail.com>
Yep until the plot is fine, I am also fine removing line of code :) |
Plots look good too now ! |
Can this be merged? |
…earn#24692) Co-authored-by: Tim Head <betatim@gmail.com>
…earn#24692) Co-authored-by: Tim Head <betatim@gmail.com>
closes #24685
Adapt code to not raise deprecation warning issue by
matplotlib
andKMeans