DOC Improve narrative of plot_roc_crossval example #24710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto plot_roc_cv
glemaitre
reviewed
Oct 23, 2022
glemaitre
reviewed
Oct 23, 2022
glemaitre
reviewed
Oct 23, 2022
glemaitre
reviewed
Oct 23, 2022
glemaitre
approved these changes
Oct 23, 2022
There was a problem hiding this comment.
LGTM. I only propose minor changes.
Nice improvement. Thanks @ArturoAmorQ
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
The failure is unrelated and should have been fixed in #24739 |
|
LGTM. Thanks @ArturoAmorQ |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
andportnoy
pushed a commit
to andportnoy/scikit-learn
that referenced
this pull request
Nov 5, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up of #24200.
What does this implement/fix? Explain your changes.
This PR implements cosmetic changes to the plot_roc_crossval example with the intention of making the contents more didactic.
Any other comments?
Notebook style was already implemented, but the narrative can benefit from a "tutorialization".