MAINT force NumPy version for building scikit-learn for CPython 3.10 in Windows #24742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
commented
Oct 24, 2022
pyproject.toml
Outdated
| @@ -9,6 +9,7 @@ requires = [ | |||
| # wheels on PyPI | |||
| # | |||
| # see: https://github.com/scipy/oldest-supported-numpy/blob/main/setup.cfg | |||
| "numpy==1.22.3; python_version=='3.10' and platform_system=='Windows' and platform_python_implementation != 'PyPy'", | |||
| "oldest-supported-numpy", | |||
There was a problem hiding this comment.
The marker not does not exist in the grammar defined by the PEP508.
I am wondering if changing the order would be enough then:
- if we have the first match then it will install NumPy 1.22.3
- otherwise, it will default to the oldest compatible NumPy
@ogrisel do you know if the ordering has an impact?
There was a problem hiding this comment.
I have no idea. Maybe @rgommers knows?
Otherwise, we can compute the negation ourselves:
"oldest-supported-numpy; python_version!='3.10' or platform_system!='Windows' or platform_python_implementation=='PyPy'",
"numpy==1.22.3; python_version=='3.10' and platform_system=='Windows' and platform_python_implementation != 'PyPy'",
I am not sure if python_version != '3.10' is the exact negation of python_version= ='3.10' and I am not sure about the use of whitespaces around operators.
BTW could you include a link to the original issue with the discussion that led to this PR?
There was a problem hiding this comment.
Disjunctive Normal Form for the win!
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
ogrisel
approved these changes
Oct 25, 2022
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 26, 2022
…in Windows (scikit-learn#24742) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Oct 26, 2022
…in Windows (#24742) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
…in Windows (scikit-learn#24742) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
andportnoy
pushed a commit
to andportnoy/scikit-learn
that referenced
this pull request
Nov 5, 2022
…in Windows (scikit-learn#24742) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24604
As specified in #24604 (comment), SciPy requires at least NumPy 1.22.3 with CPython 3.10 in Windows.
Unfortunately,
oldest-supported-numpyset the minimum version to1.21.6in this configuration and we, therefore, need to overwrite the NumPy version for this configuration.